Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checksum address output in log_address event and broadcast files #2975

Closed
ckoopmann opened this issue Aug 27, 2022 · 1 comment
Closed

Checksum address output in log_address event and broadcast files #2975

ckoopmann opened this issue Aug 27, 2022 · 1 comment
Labels
C-forge Command: forge Cmd-forge-script Command: forge script good first issue Good for newcomers T-feature Type: feature

Comments

@ckoopmann
Copy link
Contributor

Component

Forge

Describe the feature you would like

Current Behaviour

Addresses emitted in log events as well as broadcast json-files are not checksumed.
This leads to compiler errors when copy pasting this address back into a script etc.

While there is a workaround using forge fmt this is suboptimal since it introduces another unnecessary command / step and also negates the original purpose of checksums protecting against accidental modification of the value.

Proposed Behaviour

Emit only checksummed addresses both in log events as well as broadcast json-files.

Additional context

Can be seen as an extension of: #2674

@tgfukuda
Copy link
Contributor

tgfukuda commented Sep 6, 2022

Is it ok to try this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-forge Command: forge Cmd-forge-script Command: forge script good first issue Good for newcomers T-feature Type: feature
Projects
Archived in project
Development

No branches or pull requests

4 participants