Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(forge): custom errors are not decoded in invariant test traces #4178

Closed
PaulRBerg opened this issue Jan 25, 2023 · 0 comments · Fixed by #7559
Closed

bug(forge): custom errors are not decoded in invariant test traces #4178

PaulRBerg opened this issue Jan 25, 2023 · 0 comments · Fixed by #7559
Labels
T-feature Type: feature

Comments

@PaulRBerg
Copy link
Contributor

PaulRBerg commented Jan 25, 2023 •
edited
Loading

Component

Forge

Describe the feature you would like

Custom errors are not decoded in invariant test traces:

  [87114] LockupLinear_Handler::createStream((48843050768258118766642263247164992475545483473374652544843776, (0x00000000000000000000000000000000000045Fe, 1051), false, 287754237733202155210052262418297055004, (7300, 19493552128, 2031), 0x000000000000000000000000000000000000075F, 0x00000000000000000000000000000000000002AE))
    ├─ [0] console::log(Bound Result, 86) [staticcall]
    │   └─ ← ()
    ├─ [0] VM::startPrank(Actor 86: [0x0871433Ba612011908963BB42a64F42d65AD2f72])
    │   └─ ← ()
    ├─ [0] VM::assume(true) [staticcall]
    │   └─ ← ()
    ├─ [0] VM::assume(false) [staticcall]
    │   └─ ← 0x464f554e4452593a3a415353554d45
    └─ ← 0x464f554e4452593a3a415353554d45

The 0x464f554e4452593a3a415353554d45 at the end is the custom error the transaction reverted with, and it is part of my code base.

Update: here's another trace:

[FAIL. Reason: Custom Error 216caf0d:(0x0000000000000000000000000000000000000009, 201181830302072226773591759703971470263002656411)]
@PaulRBerg PaulRBerg added the T-feature Type: feature label Jan 25, 2023
@PaulRBerg PaulRBerg closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2023
@PaulRBerg PaulRBerg reopened this Jan 25, 2023
@mds1 mds1 mentioned this issue Feb 19, 2023
Closed
26 tasks
@mds1 mds1 mentioned this issue Feb 28, 2023
Open
@PaulRBerg PaulRBerg changed the title Custom errors not decoded in invariant test traces feat(forge): decode custom errors in invariant test traces Mar 31, 2023
@PaulRBerg PaulRBerg changed the title feat(forge): decode custom errors in invariant test traces bug(forge): custom errors are not decoded in invariant test traces Mar 31, 2023
This was referenced Apr 3, 2023
Closed
Closed
@grandizzy grandizzy mentioned this issue Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-feature Type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(invariant): decode custom error with target contract abis grandizzy/foundry
1 participant
@PaulRBerg