Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected error during genering binding for OZ 4.9.3. #6010

Closed
1 of 2 tasks
0xmikko opened this issue Oct 8, 2023 · 3 comments · Fixed by gakonst/ethers-rs#2688
Closed
1 of 2 tasks

Unexpected error during genering binding for OZ 4.9.3. #6010

0xmikko opened this issue Oct 8, 2023 · 3 comments · Fixed by gakonst/ethers-rs#2688
Labels
T-bug Type: bug

Comments

@0xmikko
Copy link

0xmikko commented Oct 8, 2023

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (fcae63a 2023-10-08T00:28:16.248807500Z)

What command(s) is the bug in?

forge bind

Operating System

Linux

Describe the bug

Steps to reproduce:

  • get OZ via NPM "@openzeppelin/contracts": "^4.9.3"
  • make a contact importing IERC20Permit
  • launch forge bind

image

However, if you skip draft-* (draft-ERC20.sol & draft-IERC20.so;) forge clean && forge b --skip draft-
And then run forge bind- it works correct

@0xmikko 0xmikko added the T-bug Type: bug label Oct 8, 2023
@gakonst gakonst added this to Foundry Oct 8, 2023
@github-project-automation github-project-automation bot moved this to Todo in Foundry Oct 8, 2023
@mattsse
Copy link
Member

mattsse commented Nov 28, 2023

This looks like a parser bug that appears to be fixed.

wasn't able to reproduce this

@0xmikko
Copy link
Author

0xmikko commented Nov 28, 2023

  1. Please, clone git clone [https://github.com/Gearbox-protocol/core-v3](https://github.com/Gearbox-protocol/core-v3.git)`
  2. yarn
  3. Run forge bind

@0xmikko
Copy link
Author

0xmikko commented Nov 29, 2023

Hi, now it generates new type of error:

Error:
failed to parse Abigen from file: "/home/mikael/Coding/tt/core-v3/forge-out/draft-IERC20Permit.sol/draft-IERC20Permit.json"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants