cast tx --raw should format typed txs as enveloped encoded txs

[mattsse]

Component

Cast

Describe the feature you would like

currently

foundry/crates/cast/bin/opts.rs

Lines 397 to 399 in 5692c5c

	/// Print the raw RLP encoded transaction.
	#[clap(long, conflicts_with = "field")]
	raw: bool,

which adheres to the help message:

foundry/crates/cast/src/lib.rs

Lines 662 to 663 in 5692c5c

	Ok(if raw {
	format!("0x{}", hex::encode(tx.rlp()))

however this does not include the type identifier for typed txs.
usually "raw", like in eth_sendRawTransaction refers to the EIP-2718 typed transaction envelope format

ref https://eips.ethereum.org/EIPS/eip-2718

TODO

• change help message
• format typed txs in developed format (prefix with with type byte)

cc @DaniPopes

Additional context

No response

[DaniPopes]

The .rlp() is already prefixed with the TX type, should it also be prefixed with the RLP header?
cc @Rjected
ref #6327

[Rjected]

There shouldn't be an RLP header before the type byte for eth_sendRawTransaction

[bernard-wagner]

I wrote the cast tx --raw code and have been using it with eth_sendRawTransaction and comparing the results with https://etherscan.io/getRawTx?tx=0x.

Is this still an issue or can we close it? If some work is still needed, happy to look at it again.

[DaniPopes]

I think there was a misunderstanding when this issue was opened