Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: invalid sender error when using Trezor with forge script with --broadcast flag #7342

Closed
klkvr opened this issue Mar 8, 2024 · 3 comments
Assignees
Labels
A-compatibility Area: compatibility Cmd-forge-script Command: forge script T-bug Type: bug T-to-investigate Type: to investigate T-to-reproduce Type: requires reproduction

Comments

@klkvr
Copy link
Member

klkvr commented Mar 8, 2024

#7141 probably introduced some regeression for trezor signers: https://t.me/foundry_support/51031

"Invalid sender" error when using Trezor with forge script and the --broadcast flag.

Command: forge script script/myscript --rpc-url $MAINNET_RPC_URL --mnemonic-derivation-paths "myderivation" --trezor --broadcast -vvvv --sender myaddr --sig "something"

  • Works without the --broadcast flag.
  • Issue arises with Trezor and the --broadcast flag.
@klkvr klkvr added the T-bug Type: bug label Mar 8, 2024
@zerosnacks zerosnacks added T-to-reproduce Type: requires reproduction T-to-investigate Type: to investigate A-compatibility Area: compatibility labels Jul 12, 2024
@zerosnacks zerosnacks changed the title Issues with trezors bug: invalid sender error when using Trezor with forge script with --broadcast flag Jul 12, 2024
@zerosnacks zerosnacks added the Cmd-forge-script Command: forge script label Jul 12, 2024
@zerosnacks
Copy link
Member

@zerosnacks
Copy link
Member

Related PR: alloy-rs/alloy#1045 including possible fix: trezor/trezor-firmware#3952 (comment)

@zerosnacks
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compatibility Area: compatibility Cmd-forge-script Command: forge script T-bug Type: bug T-to-investigate Type: to investigate T-to-reproduce Type: requires reproduction
Projects
None yet
Development

No branches or pull requests

2 participants