Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow evm_version config to be defined inline #8564

Closed
gsalzer opened this issue Jul 30, 2024 · 2 comments · Fixed by #9430
Closed

feat: allow evm_version config to be defined inline #8564

gsalzer opened this issue Jul 30, 2024 · 2 comments · Fixed by #9430
Assignees
@DaniPopes
Labels
A-cheatcodes Area: cheatcodes C-forge Command: forge P-normal Priority: normal T-feature Type: feature
Milestone
v1.0.0

Comments

@gsalzer
Copy link

gsalzer commented Jul 30, 2024

Component

Forge

Describe the feature you would like

I propose a cheat code that allows to set the EVM version for the current test, ideally with the possibility to execute different tests in a file with different EVM versions (thinking of other Ethereum chains, it might be even interesting to (de)activate single EIPs of main chain forks). This is not covered by specifying the EVM version for solc, as we might want to test a code compiled for a particular EVM version for subsequent EVM versions. Or test a code for other chains that have activated different features.

Additional context

No response
@gsalzer gsalzer added the T-feature Type: feature label Jul 30, 2024
@gsalzer gsalzer changed the title configure/specify evm version for tests configure/specify EVM version for tests Jul 30, 2024
@zerosnacks zerosnacks added the A-config Area: config label Jul 30, 2024
@zerosnacks zerosnacks changed the title configure/specify EVM version for tests feat(config): configure/specify EVM version for tests Jul 30, 2024
@zerosnacks zerosnacks added C-forge Command: forge A-config Area: config and removed A-config Area: config labels Jul 30, 2024
@zerosnacks zerosnacks added this to the v1.0.0 milestone Jul 30, 2024
@zerosnacks zerosnacks changed the title feat(config): configure/specify EVM version for tests feat(cheatcodes): add cheatcode to configure/specify EVM version on a per-test basis Jul 31, 2024
@zerosnacks zerosnacks added A-cheatcodes Area: cheatcodes and removed A-config Area: config labels Jul 31, 2024
@jenpaff jenpaff removed this from the v1.0.0 milestone Sep 26, 2024
@grandizzy
Copy link
Collaborator

we're looking into making these configs available inline for transient tests #6908 (comment) and evm version will also be available to configure inline / per test

@grandizzy grandizzy added T-post-V1 Area: to tackle after V1 and removed T-post-V1 Area: to tackle after V1 labels Nov 7, 2024
@grandizzy grandizzy added this to the v1.0.0 milestone Nov 7, 2024
@grandizzy grandizzy changed the title feat(cheatcodes): add cheatcode to configure/specify EVM version on a per-test basis feat: allow evm_version config to be defined inline Nov 7, 2024
@grandizzy grandizzy mentioned this issue Nov 7, 2024
Merged
@grandizzy grandizzy added the P-normal Priority: normal label Nov 12, 2024
@yash-atreya yash-atreya mentioned this issue Nov 18, 2024
Closed
3 tasks
@yash-atreya yash-atreya self-assigned this Nov 18, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Nov 18, 2024
@yash-atreya yash-atreya moved this from Todo to In Progress in Foundry Nov 18, 2024
@grandizzy
Copy link
Collaborator

ref #5371

@yash-atreya yash-atreya moved this from In Progress to Ready For Review in Foundry Nov 19, 2024
@DaniPopes DaniPopes mentioned this issue Nov 29, 2024
Merged
@DaniPopes DaniPopes assigned DaniPopes and unassigned yash-atreya Nov 30, 2024
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Foundry Dec 2, 2024
@grandizzy grandizzy moved this from Done to Completed in Foundry Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaniPopes DaniPopes

Labels
A-cheatcodes Area: cheatcodes C-forge Command: forge P-normal Priority: normal T-feature Type: feature
Projects
Foundry
Status: Completed
Milestone
v1.0.0
6 participants
@jenpaff @gsalzer @grandizzy @yash-atreya @DaniPopes @zerosnacks