You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make WireBase::verifyAlreadyComposed smarter: If the wire is not using any inputs, don't fail (Already has some check in !wire->ignoreInputTypeCheck, but it is currently still failing)
The function can be found in src -> core -> shards -> wires.cpp::49 as of commit eda72da
Rationale
(Replace `Dispatch` with `Step`)
As it stands, the following sample code retrieved from a version of the full sample code to the Yes-No Shards game tutorial will cause the end-round looped wire to be composed with a Bool input type, and then there will be a subsequent call to end-round with a different input type, causing the error Error: Attempted to call an already composed wire with a different input type! wire: end-round, old type: Bool, new type: None.
This is undesirable when the aforementioned wire does not manipulate the input at all. The compiler should recognize that the mismatch in input types does not matter for such wires
The text was updated successfully, but these errors were encountered:
TODO
Make WireBase::verifyAlreadyComposed smarter: If the wire is not using any inputs, don't fail (Already has some check in
!wire->ignoreInputTypeCheck
, but it is currently still failing)The function can be found in src -> core -> shards -> wires.cpp::49 as of commit eda72da
Rationale
(Replace `Dispatch` with `Step`)
As it stands, the following sample code retrieved from a version of the full sample code to the Yes-No Shards game tutorial will cause the
end-round
looped wire to be composed with a Bool input type, and then there will be a subsequent call toend-round
with a different input type, causing the errorError: Attempted to call an already composed wire with a different input type! wire: end-round, old type: Bool, new type: None
.This is undesirable when the aforementioned wire does not manipulate the input at all. The compiler should recognize that the mismatch in input types does not matter for such wires
The text was updated successfully, but these errors were encountered: