Non Stock Items are not filtered correctly in POS

[vr-greycube]

Information about bug

Steps to reproduce the issue

Create several service items; Maintain Stock = 0 in Item
Open POS

Observed result

Few Items with Maintain Stock unchecked are visible in POS item selector. Alternate items i.e. 2,4,6 are not filtered.

Expected result

All service items except Product Bundle items should be filtered.

Bug

Cannot remove item from list while iterating the list.

def filter_service_items(items):
	for item in items:

should be

def filter_service_items(items):
	for item in list(items):

The same bug is also in these places:

• erpnext/erpnext/stock/report/stock_ledger/stock_ledger.py

  Line 239 in 498d933

  sl_entries.remove(sle)

• erpnext/erpnext/education/doctype/program_enrollment_tool/program_enrollment_tool.py

  Line 47 in 498d933

  students.remove(student)

• erpnext/erpnext/erpnext_integrations/taxjar_integration.py

  Line 216 in 498d933

  doc.taxes.remove(tax)

• erpnext/erpnext/payroll/doctype/payroll_entry/payroll_entry.py

  Line 481 in 498d933

  emp_list.remove(employee_details)

Module

selling

Version

version-13

Installation method

No response

Relevant log output / Stack trace / Full Error Message.

No response

[nemesis189]

@vr-greycube A request was made to allow non stock items in pos as it was available in previous version, so non stock items might not be filtered at all
PR: #28998
It's not final, needs to be reviewed and improved on.

[nextchamp-saqib]

Closed with #29556