Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Employee Onboarding & Separation Improvements #29470

Closed
yadavyk opened this issue Jan 27, 2022 · 4 comments · Fixed by #29504
Closed

Employee Onboarding & Separation Improvements #29470

yadavyk opened this issue Jan 27, 2022 · 4 comments · Fixed by #29504

Comments

@yadavyk
Copy link
Contributor

yadavyk commented Jan 27, 2022

Information about bug

Reference : 26738

Issues -

EMPLOYEE ONBOARDING :

  1. Employee Onboarding link missing from Employee’s connections form.
  2. When an employee is created from Job Offer, the offer date should be mapped as is from the Job Offer record itself. Right now there’s no such mapping

Test case 3

  1. If we create employee onboarding for an employee then the details like designation, department, grade and holiday list should be fetched for that employee as per the same mentioned in the Employee record. Also employee name linkage is missing in employee onboarding record on save.

Test case 4

  1. On cancellation of employee onboarding, all the related projects and tasks get deleted altogether. The user has no way to find out if these projects or tasks got deleted. We can add a confirmation message, like something that says "If you cancel this employee onboarding record, related projects and tasks will be deleted permanently. Do you want to cancel ?" An example :

message example

  1. On cancellation of employee onboarding, if I amend the same and try to create afresh it still says that an employee onboarding record exists. So workaround is to delete the cancelled document and then create again. However let’s say for Sales Order user can still create record for same customer without having to create new record altogether.

cancel onboarding handling

Expected behaviour : While validating it should check for document status as cancelled and then let the user proceed accordingly instead of preventing the user

  1. In the project created against employee onboarding, under Start and End Dates section, there's a field called "Actual Time (in hrs)". This time is calculated based on timesheets. A small message indicating on what basis this is calculated would be helpful

image

EMPLOYEE SEPARATION :

  1. Can we completely remove the Required for Onboarding checkbox from activities child table in Employee Separation Template? This doesn't make sense to be present in the separation doctypes

image

  1. On creation of employee separation, projects and tasks are created. When viewing tasks in Gantt, all tasks are shown appropriately but in calendar view one task is missing

Incorrect task count

Test instance : https://v14-pre-release.frappe.cloud/

Module

HR

Version

V14

Installation method

No response

Relevant log output / Stack trace / Full Error Message.

No response

@yadavyk yadavyk changed the title Employee Onboarding Improvements Employee Onboarding & Separation Improvements Jan 27, 2022
@ruchamahabal
Copy link
Member

On cancellation of employee onboarding, if I amend the same and try to create afresh it still says that an employee onboarding record exists. So workaround is to delete the cancelled document and then create again. However let’s say for Sales Order user can still create record for same customer without having to create new record altogether.

This will need some handling in the framework. Even if I trigger this confirmation via msgprint + server/client_action, the standard confirm cancellation message will still be shown. Seeing 2 confirmations before cancellation will be irritating. Will cover this in the next iteration. For now I have added a toast to just inform the user about the deletion:

boarding-toast.mp4

On creation of employee separation, projects and tasks are created. When viewing tasks in Gantt, all tasks are shown appropriately but in calendar view one task is missing

Checked on the test site. The separation was for the employee "Rajesh" and all tasks are visible in the calendar. I guess you were checking them for "Amit"
calendar

@ruchamahabal
Copy link
Member

If we create employee onboarding for an employee then the details like designation, department, grade and holiday list should be fetched for that employee as per the same mentioned in the Employee record. Also employee name linkage is missing in employee onboarding record on save.

These fields are meant to be fetched from the Employee Onboarding Template field, they were not being fetched on template selection. Moved it to the "fetch from" configuration in the doctype.

If the employee is already created, then populating these fields doesn't make sense because we need them for employee creation. Hence, not fetching it from 2 sources.

@yadavyk
Copy link
Contributor Author

yadavyk commented Jan 29, 2022

On creation of employee separation, projects and tasks are created. When viewing tasks in Gantt, all tasks are shown appropriately but in calendar view one task is missing

Checked on the test site. The separation was for the employee "Rajesh" and all tasks are visible in the calendar. I guess you were checking them for "Amit" calendar

The separation is created for both employees Rajesh and Amit with equal number of tasks i.e there are 6 tasks. However for Rajesh all 6 tasks are visible on calendar but for Amit only 5 tasks are visible

@ruchamahabal
Copy link
Member

So the calendar view had an "Open" filter set by default and the "Schedule exit interview" task was in "Working" status so it was not showing up. Removed the filter and it showed up:

task-status.mp4

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants