Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance of BOM Update Tool and Correctness #30960

Closed
2 of 3 tasks
marination opened this issue May 10, 2022 · 0 comments · Fixed by #31072
Closed
2 of 3 tasks

Performance of BOM Update Tool and Correctness #30960

marination opened this issue May 10, 2022 · 0 comments · Fixed by #31072
Assignees
@marination
Labels
feature-request stock valid

Comments

@marination
Copy link
Collaborator

marination commented May 10, 2022 •
edited
Loading

Case: BOM count in the system is in Lakhs. (470K)

  • BOM Update Tool times out
  • Child rows are only updated for operating cost

Basic refactor was done in #30146

ToDo:

  • See how timeout can be optimised and notified

  • Add version log for updates made by Tool (check with perf)

  • Fix update_cost in BOM, only op cost db updates child, rest does not get updated. Also rm cost is db_updated twice. Correctness needs to be fixed and tests are needed
@ankush ankush added the valid label May 12, 2022
@marination marination linked a pull request May 23, 2022 that will close this issue
perf: BOM Update Tool #31072
Merged
1 task
@yadavyk yadavyk added the stock label Jun 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@marination marination

Labels
feature-request stock valid
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: BOM Update Tool marination/erpnext
3 participants
@ankush @marination @yadavyk