Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work Order Pick List - Error v14 #34761

Closed
dineshpanchal93 opened this issue Apr 6, 2023 · 8 comments · Fixed by #35303
Closed

Work Order Pick List - Error v14 #34761

dineshpanchal93 opened this issue Apr 6, 2023 · 8 comments · Fixed by #35303
Assignees

Comments

@dineshpanchal93
Copy link

Information about bug

https://discuss.frappe.io/t/v14-work-order-pick-list-not-working/103271

Module

manufacturing

Version

"erpnext": "14.20.0",
"frappe": "14.30.0",
"hrms": "14.2.0",
"india_compliance": "14.5.1",

Installation method

manual install

Relevant log output / Stack trace / Full Error Message.

### App Versions

{
	
	"erpnext": "14.20.2",
	"frappe": "14.31.0",
	"frappe_whatsapp": "0.0.2",
	"hrms": "14.2.1",
	"india_compliance": "14.5.1"
}

Route

Form/Work Order/WO/2304/00041

Traceback

Traceback (most recent call last):
  File "apps/frappe/frappe/app.py", line 66, in application
    response = frappe.api.handle()
  File "apps/frappe/frappe/api.py", line 54, in handle
    return frappe.handler.handle()
  File "apps/frappe/frappe/handler.py", line 45, in handle
    data = execute_cmd(cmd)
  File "apps/frappe/frappe/handler.py", line 83, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "apps/frappe/frappe/__init__.py", line 1607, in call
    return fn(*args, **newargs)
  File "apps/erpnext/erpnext/manufacturing/doctype/work_order/work_order.py", line 1474, in create_pick_list
    doc.set_item_locations()
  File "apps/erpnext/erpnext/stock/doctype/pick_list/pick_list.py", line 210, in set_item_locations
    locations = get_items_with_location_and_quantity(
  File "apps/erpnext/erpnext/stock/doctype/pick_list/pick_list.py", line 462, in get_items_with_location_and_quantity
    while remaining_stock_qty > 0 and available_locations:
TypeError: '>' not supported between instances of 'NoneType' and 'int'

Request Data

{
	"type": "POST",
	"args": {
		"source_name": "WO/2304/00041",
		"for_qty": 0
	},
	"headers": {},
	"error_handlers": {},
	"url": "/api/method/erpnext.manufacturing.doctype.work_order.work_order.create_pick_list"
}

Response Data

{
	"exception": "TypeError: '>' not supported between instances of 'NoneType' and 'int'"
}
@dineshpanchal93
Copy link
Author

dineshpanchal93 commented Apr 7, 2023

It works only when Fresh Work Order is created.

If we transfer first time the Partial qty against the work order using picklist and Stock entry is working

remaining item or shortage item needs to transfer against the work order. ( Not Working )

@dineshpanchal93
Copy link
Author

Can anyone look into priority!

@dineshpanchal93
Copy link
Author

Any update on the same

@s-aga-r
Copy link
Contributor

s-aga-r commented May 17, 2023

@dineshpanchal93 not able to replicate, could you please share the steps to replicate or a gif?

WO
image

PL[1]
image

SE[1]
image

PL[2]
image

SE[2]
image

@dineshpanchal93
Copy link
Author

Yes Sure

@dineshpanchal93
Copy link
Author

@s-aga-r

Please the attached video

Screen.Recording.2023-05-23.at.11.48.06.AM.mov

@dineshpanchal93
Copy link
Author

I can able to create the stock entry for the remaining item or shortage item. but not able to create the picklist for the same.

@s-aga-r s-aga-r self-assigned this May 23, 2023
@s-aga-r
Copy link
Contributor

s-aga-r commented May 23, 2023

@dineshpanchal93 This issue is related to #28377, ignore Partial Transfer against Work Order. You can set Overproduction Percentage For Work Order in Manufacturing Settings as a workaround for existing Work Orders. I have raised a fix so you won't get TypeError.

image

@s-aga-r s-aga-r closed this as completed May 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants