fix: depreciation schedule for existing assets [v14] #35255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandbaburajan
changed the title
|
Thanks a lot for this @anandbaburajan Hope it gets merged soon so we can test Thanks again |
mergify bot
pushed a commit
that referenced
this pull request
May 17, 2023
* fix: depreciation schedule for existing assets * chore: correct logic for existing assets and fix test (cherry picked from commit 0a080ef) # Conflicts: # erpnext/assets/doctype/asset/asset.py
anandbaburajan
added a commit
that referenced
this pull request
May 17, 2023
#35347) * fix: depreciation schedule for existing assets [v14] (#35255) * fix: depreciation schedule for existing assets * chore: correct logic for existing assets and fix test (cherry picked from commit 0a080ef) # Conflicts: # erpnext/assets/doctype/asset/asset.py * chore: fix conflict --------- Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 24, 2023
## [13.50.6](v13.50.5...v13.50.6) (2023-05-24) ### Bug Fixes * allow over-payment against SO ([#35079](#35079)) ([eb243c2](eb243c2)) * bypass flag in Customer Group wasn't effective ([f0c9d89](f0c9d89)) * change field-type to remove currency field from total row in export ([f65be40](f65be40)) * consider 0 if rate/qty are null (backport [#35338](#35338)) ([#35341](#35341)) ([387f8b9](387f8b9)) * depreciation schedule for existing assets [v14] (backport [#35255](#35255)) ([#35347](#35347)) ([7506132](7506132)) * error while saving job card ([d6427cf](d6427cf)) * get_query filters ([2aa7729](2aa7729)) * Incorrect Earned Leaves Proration ([#35156](#35156)) ([dc04b24](dc04b24)) * linter ([0a42e6f](0a42e6f)) * non manufacturing items/fixed asset items in BOM ([66ba74f](66ba74f)) * Pick List TypeError ([137898d](137898d)) * tds incorrectly calculated for invoice that are below threshold ([6c170ab](6c170ab)) * **test:** cumulative threshold checks ([06deecb](06deecb)) * use flt instead of mandatory field ([f63b866](f63b866))
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 24, 2023
# [14.25.0](v14.24.3...v14.25.0) (2023-05-24) ### Bug Fixes * consider 0 if rate/qty are null (backport [#35338](#35338)) ([#35340](#35340)) ([15c1af3](15c1af3)) * Creating landed cost voucher from connections ([2631224](2631224)) * depreciation schedule for existing assets [v14] ([#35255](#35255)) ([0a080ef](0a080ef)) * don't recalculate rate for SCR rejected warehouse SLE ([633a170](633a170)) * error while saving job card ([fb7d3b7](fb7d3b7)) * incorrect depr schedule and posting dates on selling of existing assets [v14] ([#35396](#35396)) ([8af6a11](8af6a11)) * Pick List Status ([4888436](4888436)) * Pick List TypeError ([6df9b53](6df9b53)) * possible type error on quotation -> sales order creation ([d23b93a](d23b93a)) * replace quotation with invoice in first onboarding (backport [#35389](#35389)) ([#35394](#35394)) ([9b9772e](9b9772e)) * tds incorrectly calculated for invoice that are below threshold ([bdf81a4](bdf81a4)) * **test:** cumulative threshold checks ([879946e](879946e)) * use flt instead of mandatory field ([668b092](668b092)) * **ux:** SCR consumed-qty read-only property ([aa7fede](aa7fede)) ### Features * provision to make reposting entries from Stock and Account Value Comparison Report ([3a0cdf3](3a0cdf3)) * provision to skip available sub assembly items in the production plan ([ce601af](ce601af))
|
🎉 This PR is included in version 14.25.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The depreciation schedule generated for existing assets was incorrect, so fixed that. Fixes #34920 (more details here).