Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Billing Address display in buying transactions #35451

Merged
merged 1 commit into from
May 31, 2023
Merged

fix: Billing Address display in buying transactions #35451

merged 1 commit into from
May 31, 2023

Conversation

deepeshgarg007
Copy link
Member

No description provided.

@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label May 29, 2023
@github-actions github-actions bot added buying needs-tests This PR needs automated unit-tests. labels May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #35451 (c3cc669) into develop (781c93c) will increase coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #35451      +/-   ##
===========================================
+ Coverage    63.89%   63.98%   +0.09%     
===========================================
  Files          814      815       +1     
  Lines        60467    60769     +302     
===========================================
+ Hits         38638    38886     +248     
- Misses       21829    21883      +54
Impacted Files Coverage Δ
erpnext/controllers/buying_controller.py 84.02% <ø> (ø)

... and 15 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 merged commit bb21c04 into frappe:develop May 31, 2023
mergify bot pushed a commit that referenced this pull request May 31, 2023
@deepeshgarg007 @mergify
fix: Billing Address display in buying transactions (#35451)
37505e6 
(cherry picked from commit bb21c04)
@mergify mergify bot mentioned this pull request May 31, 2023
Merged
deepeshgarg007 added a commit that referenced this pull request May 31, 2023
@mergify @deepeshgarg007
fix: Billing Address display in buying transactions (#35451)
33e8d05 
fix: Billing Address display in buying transactions (#35451)

(cherry picked from commit bb21c04)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request May 31, 2023
@frappe-bot
chore(release): Bumped to Version 14.26.0
69b214b 
# [14.26.0](v14.25.1...v14.26.0) (2023-05-31)

### Bug Fixes

* account group totals calculation to consider include_in_gross ([8dcb930](8dcb930))
* add total col for gross and net profit ([cb9b4fb](cb9b4fb))
* available qty not fetching for raw material in PP ([746a734](746a734))
* balance quantity ([56ba7d6](56ba7d6))
* Billing Address display in buying transactions ([#35451](#35451)) ([33e8d05](33e8d05))
* don't map items twice ([6f0c7cf](6f0c7cf))
* Error while validating budget ([#35487](#35487)) ([5fd00e7](5fd00e7))
* **Gross Profit:** 'company' column is ambiguous in filter ([a59c205](a59c205))
* incorrect `POS Reserved Qty` in `Stock Projected Qty` Report ([71e4f34](71e4f34))
* incorrect available quantity in BIN ([5a9452f](5a9452f))
* incorrect transferred qty in the job card ([#35478](#35478)) ([86801c2](86801c2))
* make DN item reference mandatory for Packing Slip Item ([b4e481a](b4e481a))
* map `Packed Items` while creating `Packing Slip` ([984e32c](984e32c))
* monthly WDV depr schedule for existing assets [v14] ([#35458](#35458)) ([37d437a](37d437a))
* Negative value in Reserved Qty for Production Plan ([6fe42c9](6fe42c9))
* Packing Slip Item Qty ([5345ebe](5345ebe))
* **patch:** add patch to set `packed_qty` in draft DN ([b3da2f7](b3da2f7))
* rate not fetching properly for inter transfer purchase order ([7b75f45](7b75f45))
* remove duplicate items validation ([c7628c9](c7628c9))
* retention stock entry: grab conversion factor from source ([bd75584](bd75584))
* Show future payments in accounts receivable summary ([#35416](#35416)) ([11440cc](11440cc))
* Stock Analytics and Warehouse wise Item Balance Age and Value issue ([2058993](2058993))
* stock onboarding (backport [#35453](#35453)) ([#35480](#35480)) ([d231b19](d231b19))
* tab-uniformity (backport [#35400](#35400)) ([#35402](#35402)) ([989052c](989052c))
* travis ([fe1e2fe](fe1e2fe))
* update `Packed Qty` in DN on submit and cancel of `Packing Slip` ([0bed062](0bed062))
* **ux:** don't show `Create > Packing Slip` button if items are already packed ([9854c84](9854c84))
* **ux:** get items on selecting DN in Packing Slip ([b96aa75](b96aa75))
* **ux:** remove `Get Items` button from `Packing Slip` ([4017342](4017342))
* validate Packing Slip Item Qty with DN Items ([cc7e267](cc7e267))

### Features

* add field `Packed Qty` in `Delivery Note Item` and `Packed Item` ([509b684](509b684))
* add field `pi_detail` in `Packing Slip` ([2b75474](2b75474))
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 buying needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deepeshgarg007