-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Error while validating budget #35487
Merged
deepeshgarg007
merged 3 commits into
frappe:develop
from
deepeshgarg007:tree_accounting_dimension_budget
May 31, 2023
Merged
fix: Error while validating budget #35487
deepeshgarg007
merged 3 commits into
frappe:develop
from
deepeshgarg007:tree_accounting_dimension_budget
May 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #35487 +/- ##
========================================
Coverage 63.98% 63.98%
========================================
Files 815 815
Lines 60767 60769 +2
========================================
+ Hits 38880 38886 +6
+ Misses 21887 21883 -4
|
mergify bot
pushed a commit
that referenced
this pull request
May 31, 2023
* fix: Error while validating budget * chore: remove print statement (cherry picked from commit 27d5e6a)
deepeshgarg007
added a commit
that referenced
this pull request
May 31, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 31, 2023
# [14.26.0](v14.25.1...v14.26.0) (2023-05-31) ### Bug Fixes * account group totals calculation to consider include_in_gross ([8dcb930](8dcb930)) * add total col for gross and net profit ([cb9b4fb](cb9b4fb)) * available qty not fetching for raw material in PP ([746a734](746a734)) * balance quantity ([56ba7d6](56ba7d6)) * Billing Address display in buying transactions ([#35451](#35451)) ([33e8d05](33e8d05)) * don't map items twice ([6f0c7cf](6f0c7cf)) * Error while validating budget ([#35487](#35487)) ([5fd00e7](5fd00e7)) * **Gross Profit:** 'company' column is ambiguous in filter ([a59c205](a59c205)) * incorrect `POS Reserved Qty` in `Stock Projected Qty` Report ([71e4f34](71e4f34)) * incorrect available quantity in BIN ([5a9452f](5a9452f)) * incorrect transferred qty in the job card ([#35478](#35478)) ([86801c2](86801c2)) * make DN item reference mandatory for Packing Slip Item ([b4e481a](b4e481a)) * map `Packed Items` while creating `Packing Slip` ([984e32c](984e32c)) * monthly WDV depr schedule for existing assets [v14] ([#35458](#35458)) ([37d437a](37d437a)) * Negative value in Reserved Qty for Production Plan ([6fe42c9](6fe42c9)) * Packing Slip Item Qty ([5345ebe](5345ebe)) * **patch:** add patch to set `packed_qty` in draft DN ([b3da2f7](b3da2f7)) * rate not fetching properly for inter transfer purchase order ([7b75f45](7b75f45)) * remove duplicate items validation ([c7628c9](c7628c9)) * retention stock entry: grab conversion factor from source ([bd75584](bd75584)) * Show future payments in accounts receivable summary ([#35416](#35416)) ([11440cc](11440cc)) * Stock Analytics and Warehouse wise Item Balance Age and Value issue ([2058993](2058993)) * stock onboarding (backport [#35453](#35453)) ([#35480](#35480)) ([d231b19](d231b19)) * tab-uniformity (backport [#35400](#35400)) ([#35402](#35402)) ([989052c](989052c)) * travis ([fe1e2fe](fe1e2fe)) * update `Packed Qty` in DN on submit and cancel of `Packing Slip` ([0bed062](0bed062)) * **ux:** don't show `Create > Packing Slip` button if items are already packed ([9854c84](9854c84)) * **ux:** get items on selecting DN in Packing Slip ([b96aa75](b96aa75)) * **ux:** remove `Get Items` button from `Packing Slip` ([4017342](4017342)) * validate Packing Slip Item Qty with DN Items ([cc7e267](cc7e267)) ### Features * add field `Packed Qty` in `Delivery Note Item` and `Packed Item` ([509b684](509b684)) * add field `pi_detail` in `Packing Slip` ([2b75474](2b75474))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #35450