From 571c977e8e871ff1b12350fc85fc3a995a34789a Mon Sep 17 00:00:00 2001 From: Deepesh Garg Date: Fri, 16 Jun 2023 12:17:31 +0530 Subject: [PATCH] fix: Incorrect field while calculating Tax withholding net total --- .../tax_withholding_category.py | 22 +++++++++++-------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py b/erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py index 6c11e51b2676..86c6341b68df 100644 --- a/erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py +++ b/erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py @@ -518,15 +518,19 @@ def get_invoice_total_without_tcs(inv, tax_details): def get_tds_amount_from_ldc(ldc, parties, pan_no, tax_details, posting_date, net_total): tds_amount = 0 - limit_consumed = frappe.db.get_value( - "Purchase Invoice", - { - "supplier": ("in", parties), - "apply_tds": 1, - "docstatus": 1, - "posting_date": ("between", (ldc.valid_from, ldc.valid_upto)), - }, - "sum(tax_withholding_net_total)", + + limit_consumed = flt( + frappe.db.get_all( + "Purchase Invoice", + filters={ + "supplier": ("in", parties), + "apply_tds": 1, + "docstatus": 1, + "tax_withholding_category": ldc.tax_withholding_category, + "posting_date": ("between", (ldc.valid_from, ldc.valid_upto)), + }, + fields=["sum(base_net_total) as limit_consumed"], + )[0].get("limit_consumed") ) if is_valid_certificate(