Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static data downloader language not found crash #202

Closed
fraxiinus opened this issue Aug 3, 2022 · 0 comments · Fixed by #204
Closed

Static data downloader language not found crash #202

fraxiinus opened this issue Aug 3, 2022 · 0 comments · Fixed by #204
Assignees
@fraxiinus
Labels
bug Something isn't working
Milestone
Release 1.6.1

Comments

@fraxiinus
Copy link
Owner

Static data downloader causes crash if language does not exist in CDragon

ERROR | 2022-08-02T22:09:46 | MainWindow.xaml.cs -> .ctor() -> 53 | System.Net.Http.HttpRequestException: HTTP request to Community Dragon failed on 404, https://raw.communitydragon.org/8.1/plugins/rcp-be-lol-game-data/global/zh_tw/v1/perks.json
at Fraxiinus.ReplayBook.StaticData.Data.CommunityDragonClient.GetRuneStatDescriptions(List`1 runes, String version, String language, CancellationToken cancellationToken)
at Fraxiinus.ReplayBook.StaticData.StaticDataManager.DownloadProperties(String patchVersion, StaticDataType types, String language, CancellationToken cancellationToken)
at Fraxiinus.ReplayBook.UI.Main.Views.StaticDataAddDialog.DownloadButton_Click(Object sender, RoutedEventArgs e)
at System.Threading.Tasks.Task.<>c.b__128_0(Object state)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
@fraxiinus fraxiinus added the bug Something isn't working label Aug 3, 2022
@fraxiinus fraxiinus added this to the Next Release milestone Aug 3, 2022
@fraxiinus fraxiinus self-assigned this Sep 9, 2022
@fraxiinus fraxiinus mentioned this issue Sep 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fraxiinus fraxiinus

Labels
bug Something isn't working
Projects
ReplayBook Work Items
Status: Completed
Milestone
Release 1.6.1
Development

Successfully merging a pull request may close this issue.

Consolidate static data downloads into dialog fraxiinus/ReplayBook
1 participant
@fraxiinus