Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-deselect problem #1334

Closed

Conversation

nikolawannabe
Copy link

@nikolawannabe nikolawannabe commented Sep 22, 2016

When multiple styles are being deselected without
entering new text, the styles that have already
been deselected previously would become accidentally
reselected.

This fixes #1333.

When multiple styles are being deselected without
entering new text, the styles that have already
been deselected previous would become accidentally
reselected.

This fixes textAngular#1333.
JoelParke added a commit to JoelParke/textAngular that referenced this pull request Oct 2, 2016
@JoelParke
Copy link
Collaborator

THANKS very much for this fix! I have integrated into the master with:
64d0c4a
It's still not perfect because of Rangy.saveSelection(), but your changes have improved it greatly!

@JoelParke JoelParke closed this Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bold and Italics buttons can't be (de)pressed one straight after the other
2 participants