Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Older internet explorer autolinks text #475

Closed
iainbeeston opened this issue Jan 6, 2015 · 2 comments
Closed

Older internet explorer autolinks text #475

iainbeeston opened this issue Jan 6, 2015 · 2 comments

Comments

@iainbeeston
Copy link
Contributor

I've noticed that the content editable tag created by the text-angular directive does slightly strange things on internet explorer. Notably, if you type in a url, IE9 automatically converts it to an <a href="..."> tag. That may or may not be a problem (depending on your app), but the user hasn't explicitly made that text into a link (as they would have to do for other browsers - so it's inconsistent).

Apparently this can be fixed (in IE>=5.5) by calling el.execCommand("AutoUrlDetect", false, false) (see here).

I'm fine with doing that myself on my own project, but I figured it should probably be the default on text-angular? Or at least something that has a known fix.

@iainbeeston
Copy link
Contributor Author

I'm not 100% sure if you can call execCommand() on a particular content editable tag, or if it has to be on the document (in which case it might be a bad idea to include this in text-angular, but perhaps it'd be worth recording the fix somewhere?)

@SimeonC
Copy link
Collaborator

SimeonC commented Jan 6, 2015

Thanks for posting up the issue and fix, execCommand unfortunately cannot be called on a specific instance AFAIK, for now I'll just document it in the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants