Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #1 #3

Merged
merged 2 commits into from
Oct 14, 2011
Merged

Fixed issue #1 #3

merged 2 commits into from
Oct 14, 2011

Conversation

icetbr
Copy link
Contributor

@icetbr icetbr commented Oct 13, 2011

@ghost
Copy link

ghost commented Oct 13, 2011

Nice work. I had actually started creating a language file from scratch. I believe this repo is adapted from the HAML bundle, and there are a lot of artifacts thereof. Still, getting the regex to work is quite a challenge, particularly in the sense that slim syntax forgoes a lot of delimiters. Your work is a big improvement though.

@icetbr
Copy link
Contributor Author

icetbr commented Oct 13, 2011

Thanks. It was a very small change, that took quite some time to figure it out. I'm no expert in regex. Also, the multi-line static content I didn't even bother to try :-) I'm sure there is some clever/simple regex trick to get it right. Hopefully this change will do until your version is ready!

fredwu added a commit that referenced this pull request Oct 14, 2011
Fixed issue #1 - better syntax highlighting
@fredwu fredwu merged commit e6a3a0f into slim-template:master Oct 14, 2011
@fredwu
Copy link
Member

fredwu commented Oct 14, 2011

Great work @icetbr! Merged! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

difference between id, class, tag highlighting
2 participants