Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(curriculum): adding node and express challenges to cert #56080

Merged
merged 4 commits into from
Sep 18, 2024
Merged

feat(curriculum): adding node and express challenges to cert #56080

merged 4 commits into from
Sep 18, 2024

Conversation

jdwilkin4
Copy link
Contributor

@jdwilkin4 jdwilkin4 commented Sep 12, 2024 •
edited
Loading

Checklist:

Closes freeCodeCamp/CurriculumExpansion#559

@jdwilkin4 jdwilkin4 self-assigned this Sep 12, 2024
@jdwilkin4 jdwilkin4 requested a review from a team as a code owner September 12, 2024 13:38
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels Sep 12, 2024
@jdwilkin4 jdwilkin4 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 12, 2024
moT01
moT01 reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Looks like there's a conflict.

@ilenia-magoni
Copy link
Contributor

ilenia-magoni commented Sep 13, 2024 •
edited
Loading

now there is merge conflict, @moT01 can you fix the duplicate id test so we don't have to do that?

@ilenia-magoni ilenia-magoni added status: merge conflict To be applied to PR's that have a merge conflict and need updating and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Sep 13, 2024
@moT01 moT01 mentioned this pull request Sep 13, 2024
Merged
4 tasks
@jdwilkin4 jdwilkin4 added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: merge conflict To be applied to PR's that have a merge conflict and need updating labels Sep 13, 2024
@zairahira
Copy link
Member

I went through the individual sections, they seem good to go.
However, this is how the "Basic Node and Express" section is showing on the main page:

image

@jdwilkin4
Copy link
Contributor Author

jdwilkin4 commented Sep 17, 2024 •
edited
Loading

@zairahira

That is because some recent UI changes broke the design for these challenges.
there is already a PR in the works to fix this

@moT01 moT01 merged commit 88b999d into freeCodeCamp:main Sep 18, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moT01 moT01 moT01 approved these changes

@zairahira zairahira zairahira approved these changes

Assignees

@jdwilkin4 jdwilkin4

Labels
frontend cert platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: node and express challenges to frontend cert in main repo
4 participants
@jdwilkin4 @ilenia-magoni @zairahira @moT01