Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(curriculum): adding boilerplate workshop to cert #56083

Merged
merged 4 commits into from
Sep 16, 2024
Merged

feat(curriculum): adding boilerplate workshop to cert #56083

merged 4 commits into from
Sep 16, 2024

Conversation

jdwilkin4
Copy link
Contributor

Checklist:

Closes freeCodeCamp/CurriculumExpansion#570

@jdwilkin4 jdwilkin4 self-assigned this Sep 12, 2024
@jdwilkin4 jdwilkin4 requested a review from a team as a code owner September 12, 2024 14:36
@github-actions GitHub Actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels Sep 12, 2024
@jdwilkin4 jdwilkin4 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 12, 2024
moT01
moT01 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

After conflicts fixed.

@moT01 moT01 mentioned this pull request Sep 13, 2024
Merged
4 tasks
@jdwilkin4 jdwilkin4 added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP status: merge conflict To be applied to PR's that have a merge conflict and need updating and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Sep 13, 2024
@jdwilkin4 jdwilkin4 added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP status: merge conflict To be applied to PR's that have a merge conflict and need updating labels Sep 13, 2024
Dario-DC
Dario-DC requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@Dario-DC Dario-DC left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't appear like this, is that right?
image

@jdwilkin4
Copy link
Contributor Author

jdwilkin4 commented Sep 16, 2024 •
edited
Loading

@Dario-DC

If I reverse the UI changes made in this PR here it works as expected
https://github.com/freeCodeCamp/freeCodeCamp/pull/56090/files

Screenshot 2024-09-16 at 6 55 27 AM

so we should leave those fixes to the open PR here
https://github.com/freeCodeCamp/freeCodeCamp/pull/56101/files

@Dario-DC Dario-DC merged commit e90e5ff into freeCodeCamp:main Sep 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moT01 moT01 moT01 approved these changes

@Dario-DC Dario-DC Dario-DC approved these changes

Assignees

@jdwilkin4 jdwilkin4

Labels
frontend cert platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: add Learn Bash by Building a Boilerplate workshop to main repo
3 participants
@jdwilkin4 @moT01 @Dario-DC