Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(curriculum): adding student database workshops to cert #56114

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

jdwilkin4
Copy link
Contributor

Checklist:

Closes freeCodeCamp/CurriculumExpansion#575
closes freeCodeCamp/CurriculumExpansion#574

@jdwilkin4 jdwilkin4 self-assigned this Sep 15, 2024
@jdwilkin4 jdwilkin4 requested a review from a team as a code owner September 15, 2024 18:21
@github-actions GitHub Actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels Sep 15, 2024
@jdwilkin4 jdwilkin4 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 15, 2024
@ilenia-magoni
Copy link
Contributor

maybe these two could be combined in a single block?

@jdwilkin4
Copy link
Contributor Author

maybe these two could be combined in a single block?

The original relational database curriculum is split into two blocks, so I vote we leave it as is since there is probably a reason why Tom structured it that way

@moT01
Copy link
Member

moT01 commented Sep 16, 2024

Yea, keep them separate. I split it because it was really long. It's kinda neat, at the end of the first one, they save a dump of their DB - and then restore it on at the start of the second.

@ilenia-magoni
Copy link
Contributor

I meant having part 1 and part 2 being like step 1 and step 2 of the same block, not merging the two together completely, but if you say separate is better, let's keep it separate

Copy link
Contributor

@Dario-DC Dario-DC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Dario-DC Dario-DC merged commit e0c318a into freeCodeCamp:main Sep 17, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend cert platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
4 participants