Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document somewhere that unsent replies are visible to all users #1190

Open
redshiftzero opened this issue Nov 17, 2020 · 4 comments
Open

document somewhere that unsent replies are visible to all users #1190

redshiftzero opened this issue Nov 17, 2020 · 4 comments

Comments

@redshiftzero
Copy link
Contributor

It may not be clear to users (despite SD's shared inbox) that replies that fail to send (i.e. those that are in "draft" form) are visible to all users of that workstation, including those that are not logged in to the client.

@ninavizz
Copy link
Member

I'd thought draft messages were not a feature in the Workstation, yet? Are you referencing the bounced message w/ the error bubble?

Off the top of my head, I'm not sure it would even occur to a user that some parts of the UI are visible to others, and some aren't. Especially when these failures are clearly indicated as a non-cancellable state in-context, vs as toast messages. Agreed wrt documentation "somewhere," but I don't feel it needs to either be in the UI or in the primary user guide.

@eloquence
Copy link
Member

I think a note in the primary user guide that if a reply failed to send, other users on the same system will be able to see it, would be appropriate.

@gonzalo-bulnes
Copy link
Contributor

gonzalo-bulnes commented Feb 8, 2022

Taking a mental note here that I find the name "draft reply" somewhat unexpected. I think I'd get a better intuition of what they are if they were called "failed replies" or something along those lines. Edit: If I understand well, "draft" is a state before the reply fails, so my suggestion wasn't that good either.

@cfm cfm changed the title document somewhere that failed replies (i.e. drafts) are visible to all users document somewhere that unsent replies are visible to all users May 11, 2023
@cfm
Copy link
Member

cfm commented May 11, 2023

[In the neighborhood for #1634:] I'm curious if we have a clear use-case or user story for this behavior. It seems to me that it:

  1. entrenches a state partition between the Client and Server;
  2. requires edge-case handling in the current sending and sync implementation; and
  3. may apparently surprise users enough to warrant documenting explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants