Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecureDrop Client localization workflow follow-up #1302

Closed
5 of 7 tasks
Tracked by #1294 ...
cfm opened this issue Sep 22, 2021 · 2 comments
Closed
5 of 7 tasks
Tracked by #1294 ...

SecureDrop Client localization workflow follow-up #1302

cfm opened this issue Sep 22, 2021 · 2 comments
Assignees
Labels

Comments

@cfm
Copy link
Member

cfm commented Sep 22, 2021

try

#1282's post-merge steps were:

  1. https://weblate.securedrop.org/settings/securedrop/securedrop-client/#vcs: Change Repository Branch to main
  2. Monitor daily l10n GitHub Actions workflow for successful update-translation-catalogs

except

These turn out to need to be reversed, because:

  1. the l10n GitHub actions workflow will regenerate the securedrop_client/locale/messages.pot template...
  2. ...without which Weblate will not accept main as the new Repository Branch.

However, (1) is blocked in securedrop-client on main's branch protections, per:

finally

  1. Enable safe-html per freedomofpress/securedrop-security#65
  2. Test safe-html filtering
  3. Update status of includes compiled translation catalogs in Python source distribution #1294
@cfm cfm added the i18n label Sep 22, 2021
@cfm cfm self-assigned this Sep 22, 2021
@eloquence eloquence changed the title follow-up from #1282 SecureDrop Client localization workflow follow-up Sep 29, 2021
@cfm
Copy link
Member Author

cfm commented Oct 19, 2021

Per securedrop-security#65: The safe-html flag is now enabled for securedrop-client, in addition to the existing "Unsafe HTML" check.

@cfm
Copy link
Member Author

cfm commented Oct 20, 2021

The steps remaining here are superseded by #1317.

@cfm cfm closed this as completed Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant