Successful export yields "Unexpected Return Status" error message

[rocodes]

Description

A successful export in the client yields an error message in the export dialog. This is a recent change.

Steps to Reproduce

Run the client from a point after these changes were merged, then attempt an export. Observe logs on sd-devices.

Expected Behavior

Successful export, no errors in sd-devices logs, and confirmation message in client export dialog.

Actual Behavior

Successful export, no errors in sd-devices logs, followed by "UNEXPECTED_RETURN_STATUS" error message in export dialog:

Comments

Because a successful export currently/historically returns no status value, the changes linked above mean that the client attempts to initialize an ExportStatus enum from the empty string, yielding a ValueError.

Currently/historically, print, disk and printer-test all return without a status when they are successful (documentation) This will change with the rewrite to sd-export so that behaviour is consistent, but for now, backwards compatibility is required.

[gonzalo-bulnes]

Is 0a7f7e0#diff-3b161d8b931cce1065e57c179e7ab43bdf312ced640b3051449216295179fbf6R158 the line at fault? I think I missed that an empty string could be an expected value. 😕

Edit to add: 💡 There is no "success" value in the definition of ExportStatus! I definitely misread the code that sometimes returns an empty string.