Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File download and open not working #266

Closed
redshiftzero opened this issue Mar 11, 2019 · 1 comment · Fixed by #284
Closed

File download and open not working #266

redshiftzero opened this issue Mar 11, 2019 · 1 comment · Fixed by #284
Assignees
Labels
bug Something isn't working

Comments

@redshiftzero
Copy link
Contributor

redshiftzero commented Mar 11, 2019

STR

  1. start client, log in to server
  2. submit file as a source
  3. click on source, and double click on a document to download and open

Expected behavior

Document downloads and decrypts

Actual behavior

Traceback (most recent call last):
  File "/Users/redshiftzero/.virtualenvs/securedrop-client-l0Id-Ywn/lib/python3.5/shutil.py", line 538, in move
    os.rename(src, real_dst)
FileNotFoundError: [Errno 2] No such file or directory: '/var/folders/gv/2r10zvfj303fyd5_6yn_p0b80000gn/T/tmp.dOSXysZF/data/1-mushy_exposure-doc.gz.gpg' -> '/var/folders/gv/2r10zvfj303fyd5_6yn_p0b80000gn/T/tmp.dOSXysZF/data/1-mushy_exposure-doc.gz.gpg'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/redshiftzero/Documents/Github/securedrop-client/securedrop_client/logic.py", line 225, in <lambda>
    lambda: self.completed_api_call(new_thread_id, callback))
  File "/Users/redshiftzero/Documents/Github/securedrop-client/securedrop_client/logic.py", line 276, in completed_api_call
    user_callback(result_data, current_object=current_object)
  File "/Users/redshiftzero/Documents/Github/securedrop-client/securedrop_client/logic.py", line 622, in on_file_downloaded
    shutil.move(filename, filepath_in_datadir)
  File "/Users/redshiftzero/.virtualenvs/securedrop-client-l0Id-Ywn/lib/python3.5/shutil.py", line 552, in move
    copy_function(src, real_dst)
  File "/Users/redshiftzero/.virtualenvs/securedrop-client-l0Id-Ywn/lib/python3.5/shutil.py", line 251, in copy2
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "/Users/redshiftzero/.virtualenvs/securedrop-client-l0Id-Ywn/lib/python3.5/shutil.py", line 114, in copyfile
    with open(src, 'rb') as fsrc:
FileNotFoundError: [Errno 2] No such file or directory: '/var/folders/gv/2r10zvfj303fyd5_6yn_p0b80000gn/T/tmp.dOSXysZF/data/1-mushy_exposure-doc.gz.gpg'

Comment

A fix should include a regression test

@eloquence eloquence added the bug Something isn't working label Mar 11, 2019
@redshiftzero redshiftzero changed the title file download not working file download and open not working Mar 11, 2019
@eloquence eloquence changed the title file download and open not working File download and open not working Mar 22, 2019
@redshiftzero redshiftzero self-assigned this Mar 26, 2019
@redshiftzero
Copy link
Contributor Author

Hmm so it looks like this is resolved after #231, but the UI download icon in the conversation view does not update to open after the file download/decrypt completes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants