Network error after signing out

[eloquence]

STR:

• Send a reply that takes a while to send (easy if you can repro Replies are sometimes displayed out of order #653)
• Sign out while the reply is pending

Expected result:

• (For now) Reply immediately shows up as failed
• (Likely post-beta) A prompt warning about pending operations before signing out

Actual result:

• Reply stays in pending state, and we get a "server cannot be reached" error eventually, while the client is in offline mode.

Screenshot:

[eloquence]

(Added security label in case network operations are being attempted while the user expects to be offline, which may violate their opsec expectations.)

[eloquence]

Actually also seeing this after just signing out without doing anything, so may be related to sync or other network operations as well.

[redshiftzero]

see related change in https://github.com/freedomofpress/securedrop-client/pull/404/files#diff-dfebdbc5258e6805fadd416909ed2a90R45

when we sign out we invalidate the token, but we should probably both add some additional logic around ApiInaccessibleError (right now we pause the queue which is why this "server cannot be reached" error pops up) and either empty the queue when the user signs out or stop the threads

[sssoleileraaa]

when we sign out we invalidate the token, but we should probably both add some additional logic around ApiInaccessibleError (right now we pause the queue which is why this "server cannot be reached" error pops up)

Exactly! We should just stop the "server cannot be reached" error that results from the queue being paused (intentionally by invalidating the token) if the user is signed out

and either empty the queue when the user signs out or stop the threads

I think emptying the queue makes sense, we already persist pending replies so these should show up as failed if the user logs back in, I believe.

[sssoleileraaa]

i will work on this

[sssoleileraaa]

ah yes @rmol this is closed when #750 is merged