Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata syncs are not continuous #672

Closed
sssoleileraaa opened this issue Dec 18, 2019 · 1 comment · Fixed by #739
Closed

metadata syncs are not continuous #672

sssoleileraaa opened this issue Dec 18, 2019 · 1 comment · Fixed by #739
Assignees
Labels
bug Something isn't working release blocker

Comments

@sssoleileraaa
Copy link
Contributor

sssoleileraaa commented Dec 18, 2019

Description

Right now the queues are unpaused when either:

  • a user clicks on the retry link
  • a MetadataSyncJob succeeds

We currently pause the metadata sync queue whenever a job fails because of a request timeout or api inaccessible error. We don't want to do this. Instead metadata syncs should continuously run and retry in the background until one succeeds, and if the queues are paused, it should unpause them.

@sssoleileraaa sssoleileraaa added bug Something isn't working small off-sprint PR labels Dec 18, 2019
@sssoleileraaa sssoleileraaa changed the title Unpause queues after adding MetadataSyncJob automatic way to resume queues doesn't work when jobs other than MetadataSyncJob fail Jan 24, 2020
@sssoleileraaa
Copy link
Contributor Author

because of this issue we don't have continuous metadata syncs, and #715 moved metadata sync jobs outside of the main queue, which is a good first step, but we now need to make sure metadata syncs are never paused when there is a failure, instead we should continue to run metadata syncs in the background until one succeeds, in which case we resume the other queue jobs

@sssoleileraaa sssoleileraaa self-assigned this Jan 27, 2020
@sssoleileraaa sssoleileraaa changed the title automatic way to resume queues doesn't work when jobs other than MetadataSyncJob fail metadata syncs are not continuous Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants