-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize connection errors to "Trying to reconnect" language without Retry #811
Comments
I'm not labeling this a release blocker just yet as the behavior is confusing but not completely broken, especially once #604 (which I've marked as a release blocker) is fixed. However, I would recommend that it should at least be a very high priority once other client blockers are resolved. #798 is related to this; once the message is standardized, the MetadataSync can be another way to trigger it if it's not already being displayed. |
Resolving this issue will also resolve #676 |
@creviera I still see "Failed to update star" as a special case error message e.g. if I take down the server while the client is running. Should that also trigger the "Trying to reconnect" error or is there a reason why it shouldn't? |
I'm reopening this issue since we still have two cases where we want to display "Trying to reconnect" if there is a connection error:
|
This will be resolved in #952 and will close this issue.
This was resolved in #879 |
Description
We've agreed to the following changes to network error handling:
All network-related errors (connection errors or timeouts) should display the same error message. If the error message is already being displayed, no change to the message is necessary.
The error message should not display a "Retry" link, as the client will automatically and continuously attempt to restore connectivity.
The message should be changed to make that clearer. "The SecureDrop server cannot be reached. Trying to reconnect." sounds reasonable, but we can use this issue to kick around exact language and UI display.
The message should not be ephemeral; it should continue to be the only message displayed until connectivity is restored.
Motivation
Out of scope for this issue:
The text was updated successfully, but these errors were encountered: