Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "Active" state for Export and Print buttons #912

Closed
2 tasks
ninavizz opened this issue Mar 11, 2020 · 3 comments · Fixed by #940
Closed
2 tasks

Create "Active" state for Export and Print buttons #912

ninavizz opened this issue Mar 11, 2020 · 3 comments · Fixed by #940

Comments

@ninavizz
Copy link
Member

ninavizz commented Mar 11, 2020

Child issue w/in #910

Punchlist This Issue

Zeplin, here
(note: this mockup uses screenshots w/ graphics added where things changed, so if you're confused why some text looks odd—well, that's why!)

  • Add active-state to all primary buttons across flow(s)
  • When re-submitting a page with an error on it, either:
    • a: Clear-out the error to return the screen to its state, or
    • b: If "a" would cause the height of the screen to shorten (because the error made the screen taller) just remove the error and show whitespace. We aim for this to be an epilepsy-free experience. :D
@ninavizz
Copy link
Member Author

^ This one's also ready @ntoll! :)

@ninavizz
Copy link
Member Author

I made this GIF 3-4x as big as it needs to be, so it doesn't look sucky. Let me know if you need it to be a different size!

littlespinner-grimace

@ntoll
Copy link
Contributor

ntoll commented Mar 13, 2020

@ninavizz this spinner gif stops after X number of frames. I've GIMP-ed it a bit so it spins forever... please give me a kick on here if there's anything wrong with my version:

spinner2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants