-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Preparing to export" does not consistently transition to "Ready to export" #990
Comments
I did an Export shortly after rebooting my machine from the most recent nightly, so the |
@eloquence I've attempted to reproduce the issue described here, but it seems to be like I am observing the expected behavior. I've detailed the testing steps below, following your STR, please let me know if I missed something: In Qubes (using
As mentioned by @eloquence previously, the device doesn't re-attach when the VM reboots, the user needs to unplug/replug the device here. Perhaps the message could be more clear here? |
@emkll You are in fact observing the bug described in this issue, but it's a very subtle one. :) Note how in your second screenshot, the headline still says "Preparing to export:". However, the header should have transitioned to "Ready for export" (defined in https://github.com/freedomofpress/securedrop-client/blob/master/securedrop_client/gui/widgets.py#L2909) by this point. Note that this bug is relatively minor and the user may not even notice it - we pulled it in as a "polish" issue. #1088 is much more severe and could lead to significant confusion about export state, if we can reproduce it (but it's not technically on this sprint yet -- I'm inclined to keep it that way and nominate it for the next sprint). |
What I've found in a short exploration is that we could install a Qubes admin extension that would notice I believe @eloquence suggested that it might be simpler and less intrusive in this situation to detect that there are no usable export devices and prompt the owner to (re)attach one, and I'm inclined to agree. |
Note the report in #1018 as well, with slightly different steps to reproduce. |
This will be fixed in #1777:
|
STR in Qubes on
master
:sd-devices
running and previously downloaded files available for export.sd-devices
but do not remove USB drive. Wait for the shutdown sequence to complete.Expected behavior
"Preparing to export" transitions to "Ready to export" once VM is back up and running
Actual behavior
Header stays "Preparing to export" while spinner/button state change.
Note
This appears to be related to the USB attach state. If you shut down and restart
sd-devices
, the USB drive is no longer attached to it, and subsequent exports will fail until you manually re-attach the drive tosd-devices
through the Devices Widget. What's odd is that only the "Preparing to export" header behaves differently from the rest of the UI.The text was updated successfully, but these errors were encountered: