Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes mimeapps.list for sd-viewer #148

Merged
merged 5 commits into from
Mar 2, 2020
Merged

Fixes mimeapps.list for sd-viewer #148

merged 5 commits into from
Mar 2, 2020

Conversation

emkll
Copy link
Contributor

@emkll emkll commented Feb 28, 2020

Should be reviewed with freedomofpress/securedrop-workstation#472, test plan available in that PR description

  • fixes evince .desktop filename
  • install gedit, to view plaintext files (not included by default in buster)

@emkll
Copy link
Contributor Author

emkll commented Mar 2, 2020

CI is failing on the build-buster-securedrop-export task. In order to resolve, prior to merge, we should

Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also approving (followed test plan in freedomofpress/securedrop-workstation#472) - once CI is re-run after 0.2.1 securedrop-export tag is pushed this is good to merge

@redshiftzero redshiftzero merged commit 0c934dc into master Mar 2, 2020
@emkll emkll deleted the 455-fix-mimetypes branch March 2, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants