Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize mime handling in non-viewer VMs #455

Closed
emkll opened this issue Feb 14, 2020 · 2 comments
Closed

Standardize mime handling in non-viewer VMs #455

emkll opened this issue Feb 14, 2020 · 2 comments

Comments

@emkll
Copy link
Contributor

emkll commented Feb 14, 2020

In sd-proxy we use do-not-open-here to ensure files are not accidentally opened in that VMs opened in that VM. Give that the VM is networked, the risk of exfiltration is higher than other VMs. However, to ensure defense-in-depth and prevent accidental opening of files in VMs that are not disposable, we should consider applying this to all workstation VMs (except sd-viewer).

[1] https://github.com/freedomofpress/securedrop-workstation/tree/3d965da45dd6efe6133433b018c757e5e13324f5/sd-proxy

@conorsch
Copy link
Contributor

Great idea. Would recommend writing the mimeapps.list to private volumes, so that different VMs can have unique settings, regardless of which apt packages are installed (#471). Also useful in that home-paths override the system-level paths:

$ which gimp feh
/usr/bin/gimp
/usr/bin/feh
$ xdg-mime query default image/jpeg
gimp.desktop
$ echo -e "[Default Applications]\nimage/jpeg=feh.desktop" > ~/.config/mimeapps.list
$ xdg-mime query default image/jpeg
feh.desktop

@zenmonkeykstop
Copy link
Contributor

Closing - the default was flipped to open-in-dvm by default. This was considered safe as the default dispVM is non-networked. See freedomofpress/securedrop-builder#198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants