Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port preflight updater to Qt5 #607

Closed
eloquence opened this issue Sep 3, 2020 · 3 comments · Fixed by #610
Closed

Port preflight updater to Qt5 #607

eloquence opened this issue Sep 3, 2020 · 3 comments · Fixed by #610
Labels

Comments

@eloquence
Copy link
Member

eloquence commented Sep 3, 2020

As part of Qubes 4.1 readiness work (#600), we need to port the preflight updater to Qt5, as Qt4 is no longer supported on 4.1. This would be ideally behind a feature flag or detection logic, so we can land the change in main and easily switch over to it once 4.1 is out.

@eloquence
Copy link
Member Author

As part of the next sprint, I'd like to do a first time-boxed investigation (possibly without using a Qubes 4.1 build for testing just yet).

@eloquence
Copy link
Member Author

At first glance it looks like this should be relatively straightforward:

  1. Due to some changes in how the PyQt module namespaces are organized, a couple of import statements have to be updated.

  2. The existing Qt Designer UI can be imported into Qt Designer 5 without issues, and converted to code using pyuic5 without issues.

  3. The generated UI (here in Ubuntu) appears to look and behave the same:

Screenshot from 2020-09-04 14-51-40
Screenshot from 2020-09-04 14-51-46

Now going to look into making a Qt5 version available via feature flag.

@eloquence eloquence mentioned this issue Sep 4, 2020
7 tasks
@eloquence
Copy link
Member Author

Unless I've overlooked something major, #610 may resolve, or close to it; will do some testing in Qubes next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant