Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable 'cancel' button when Updater completes successfully #756

Closed
rocodes opened this issue Jan 25, 2022 · 2 comments
Closed

Disable 'cancel' button when Updater completes successfully #756

rocodes opened this issue Jan 25, 2022 · 2 comments
Labels
good first issue updater

Comments

@rocodes
Copy link
Contributor

rocodes commented Jan 25, 2022 •
edited
Loading

[filing this to remind myself to fix it later since it's small; it's also 'good first issue']

Currently, the "Updates complete" view does not disable the "Cancel" button, though it is disabled while the updater is running. We should either disable or hide the cancel button when updates are completed successfully.

Related: #437

should_disable_cancel_button
@eloquence
Copy link
Member

eloquence commented Jan 25, 2022 •
edited
Loading

Hm, I don't know that the current behavior is undesirable (though perhaps it could be made more intuitive) -- you can still launch the SecureDrop Client later by clicking on the desktop icon. If the first thing you want to do is something else other than logging into SD Client, backing out after updates might be the path you want to take.

@zenmonkeykstop
Copy link
Contributor

Agreed, can close this IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue updater
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eloquence @zenmonkeykstop @rocodes