-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rethink javascript warning #1024
Comments
Makes sense. |
Agreed, although NoScript still works for now (in current release TB 4.5.1) so I don't think it is urgent to make this change. The protection from the Security Slider is more holistic, so it would be good to switch over eventually. Note that the "High" security setting breaks our cute icon fonts (via Font Awesome), probably due to "some font rendering features are disabled". The breakage looks bad/sketchy. We should look into this more before recommending people switch the Security Level to "High". There are no issues on "Medium-High". |
Medium-High does not block JavaScript on non-HTTPS webpages. It would be best to figure out a different icon solution, so the page loads properly under High. I agree it looks sketchy and could potentially turn a source away with the breakage should so that should be fixed before switching this instruction. Also, users should be encouraged to reset their identity via Torbutton after switching to the High setting. |
It should be easy enough to replace the Font Awesome icons with images, instead of characters in a font. We only use a handful of them anyway. |
Should be noted this also breaks icons on the SecureDrop website and ReadTheDocs. |
Tor Browser 4.5 (and Tails 1.4) include much more fine-grained security settings than before. Rather than telling users to disable js using NoScript, I think it makes more sense to tell them to adjust to a more secure setting -- either High or Medium-High.
The text was updated successfully, but these errors were encountered: