-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Tor Browser logout instructions more user friendly #1526
Comments
Hey folks! I'm not a developer, otherwise I'd do this myself... but to those who are and would like to code this, I offer the below (with a hearty "thank you!"). Thx, @redshiftzero Note: It's important that the hue of the dialog bubble not appear red, as that's been established to cause anxiety and punitive feelings, with many users. So—just FYI. :)
Icon: in the code, please include the CC credit: Icon's SVG code: |
Hi! I'm interested in helping out with this project and it looks like these UI changes might be a good place to get started. I've noticed there are a few Issues raised for the flash messages, so I'd be happy to do all these together since they rely on underlying styles for the flash messages being altered. Has anyone started work on these yet, or are you happy for me to have a look at this? |
Hi @jcmcreate! Afaik nobody has started on this issue yet. If you would like to, by all means jump in! There is also a big list of UI changes suggested here that I'm thinking I may turn into a checklist w/ associated "sub"-issues next week (a bit disorganized as is, but great stuff nonetheless). If you do start working on something, please do make a comment on the relevant issue, so others don't also start working on it. |
@fowlslegs Thanks! I'm more than happy to work on this issue, and I'll comment in any others that I could work alongside on too. Are there any branches where the UI changes are being worked on at present? |
@jcmcreate We tend to be pretty granular with PRs when possible because it makes review easier, and we end up getting more new code in faster when we do it one little piece at a time. So in order to make your PR granular, you'll want to branch off develop and generally implement just a single feature/fix. Though, if a number of features are related feel free to implement them in the same branch/PR (e.g., you could change all the flashed messages in a single PR, but don't also change some other UI element as well). |
@fowlslegs Makes sense :) I'll do as you suggest and add all the flashes in a single PR. Some of the underlying styles for all the flashes have been altered slightly, so it would make sense to do them all in one bulk. |
This is a UX suggestion by @ninavizz to improve the notification displayed to sources upon logout (click on image below to see her suggestion for this issue in greater detail (and a nice icon we can use)):
The text was updated successfully, but these errors were encountered: