Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ci-lint fails on macOS #3996

Closed
garrettr opened this issue Dec 17, 2018 · 0 comments
Closed

make ci-lint fails on macOS #3996

garrettr opened this issue Dec 17, 2018 · 0 comments

Comments

@garrettr
Copy link
Contributor

Description

Follow-up to an issue issue I had with completing the checklist for #3994.

Steps to Reproduce

  1. Be on macOS
  2. make ci-lint

Expected Behavior

The command works.

Actual Behavior

devops/scripts/dev-shell-ci run make --keep-going lint typelint
devops/scripts/dev-shell-ci: line 23: sha256sum: command not found
make: *** [ci-lint] Error 127

Comments

sha256sum is not installed by default on macOS; however, there are plenty of other built-in tools that allow one to compute hashes. We should probably create a function that chooses the appropriate hashing tool depending on the platform it's running on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant