Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run lint, deb-tests CI jobs on builder image updates #4484

Closed
redshiftzero opened this issue May 29, 2019 · 2 comments · Fixed by #4483
Closed

Only run lint, deb-tests CI jobs on builder image updates #4484

redshiftzero opened this issue May 29, 2019 · 2 comments · Fixed by #4483

Comments

@redshiftzero
Copy link
Contributor

Description

We kick off a lot of unnecessary CI jobs for builder image update PRs:

https://circleci.com/workflow-run/08e02775-390d-4644-8524-f8af71793100

We only should keep the lint and deb-tests jobs around

@emkll
Copy link
Contributor

emkll commented May 31, 2019

I think in this case it might make sense to keep the staging-with-rebase job: While the builder tests do have some unit testing around expected files, staging-with-rebase will ensure those packages are installable on the target os. What do you think @redshiftzero ?

@redshiftzero
Copy link
Contributor Author

good point, let's keep the staging job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants