Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding LGTM code analysis to CI #4849

Closed
emkll opened this issue Sep 19, 2019 · 2 comments
Closed

Consider adding LGTM code analysis to CI #4849

emkll opened this issue Sep 19, 2019 · 2 comments

Comments

@emkll
Copy link
Contributor

emkll commented Sep 19, 2019

Description

LGTM offers static code analysis, including security vulnerabilities. It auto-detects languages (and as a result checks the (very little) JavaScript in the repo.

There are a couple of interesting findings that were missed by flake8 (non security-related) :
https://lgtm.com/projects/g/freedomofpress/securedrop/

An admin can add the integration using the marketplace, as is free for open source projects: https://github.com/marketplace/lgtm

User Stories

As a developer, I want to ensure my code is scanned for vulnerabilities and errors.

@conorsch
Copy link
Contributor

Added the integration to the securedrop repository. Haven't configured any additional checks, so there will likely be follow-up actions required. A GitHub org admin will be required for coordination there. Please list any additional steps required here, or we can coordinate in standup.

@redshiftzero
Copy link
Contributor

thanks! this is now running on PRs, so closing: #4879 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants