Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for overriding interface strings #5146

Closed
wbaid opened this issue Feb 29, 2020 · 4 comments · Fixed by #5175
Closed

support for overriding interface strings #5146

wbaid opened this issue Feb 29, 2020 · 4 comments · Fixed by #5175

Comments

@wbaid
Copy link
Contributor

wbaid commented Feb 29, 2020

Description

Our use of SecureDrop makes us an edge case: We are a nonprofit law
firm, not a newsroom. We would like our SecureDrop instance's source
interface to reflect that our "sources" are prospective clients and
our "journalists" are lawyers.

We have put together a rough prototype of how to
accomplish this kind of string-substitution while still playing
nicely with SecureDrop's translation via gettext. Before we
develop this prototype further---in particular, to hook it into the
instance_config table via the admin interface---for submission as a
pull request, we would like to invite the SecureDrop team's feedback
on our goal and approach.

  1. Is this kind of translation-respecting string-substitution a
    feature you would consider including in SecureDrop? (We are aware
    of Add injectable organization name to source/journalist interface #1575 as a rough precedent without an easy resolution.)

  2. Is this approach worth developing into a full-fledged pull
    request? or would you suggest another approach? (We have considered
    proposing administrator-configurable message catalogs, but this
    seems like a very large hammer for the very small nail we are
    trying to hit.)

User Research Evidence

We are one example of an organization whose security model benefits
from use of SecureDrop but to whom the labels "source" and "journalist"
do not apply.

User Stories

As the administrator of a non-newsroom SecureDrop instance, I would
like to be able to change the words "source" and "journalist", as
they appear on the source interface, to reflect my organization's
use-case and roles.

@eloquence
Copy link
Member

eloquence commented Mar 5, 2020

Thanks for writing this up and even putting together a proof-of-concept, and apologies for the delayed response. As a simpler alternative, what do you think about avoiding the term "journalist" in this part of the UI? There are other SecureDrop users who are not journalists (e.g., several NGOs) and we would be OK with changing to more generic term like "staff" in this case.

The word is also used in the tagline ("Protecting Journalists and Sources") and word-based substitution wouldn't really make sense here anyway ("Protecting lawyers and sources" ;-). I think for now we would want to keep that tagline as-is.

@wbaid
Copy link
Contributor Author

wbaid commented Mar 7, 2020 via email

@eloquence
Copy link
Member

Would you like us to submit a pull request with this change to the source interface's templates?

That would be great! On second thought, "our team" might work even better than "staff" in places where we use "journalists" or "our journalists".

@wbaid
Copy link
Contributor Author

wbaid commented Mar 30, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants