Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally include file attachments when generating server data with make dev #5451

Closed
sssoleileraaa opened this issue Aug 13, 2020 · 1 comment · Fixed by #5580
Closed
Labels
Hacktoberfest Issues suitable for the annual Hacktoberfest organized by Digital Ocean help wanted Issues we would definitely appreciate volunteer help with

Comments

@sssoleileraaa
Copy link
Contributor

Description

To support freedomofpress/securedrop-client#1140 and make setting up dev servers more configurable in a scriptable way, I propose that we support adding document attachments when we run make dev in a predictable way that can be used in our functional tests.

For our first iteration, the simplest thing to do would be to add a hello.txt attachment with the contents of hello, or something similar to this, across all sources in the data generated by the create_dev_data.py script. If we add a new argument called NUM_DOCS then we could default to 0 or 1 for each source, and eventually add support to randomize configuration data if we don't want all sources to have files and we want contents to vary (for uses outside of functional tests). For now, it would be a huge improvement just to be able to add a doc at make dev time.

@eloquence
Copy link
Member

+1, I've often wanted this when testing the client.

@eloquence eloquence added Hacktoberfest Issues suitable for the annual Hacktoberfest organized by Digital Ocean help wanted Issues we would definitely appreciate volunteer help with labels Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues suitable for the annual Hacktoberfest organized by Digital Ocean help wanted Issues we would definitely appreciate volunteer help with
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants