Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checklist item to PR template for addition of static assets #5646

Closed
DrGFreeman opened this issue Nov 19, 2020 · 0 comments · Fixed by #5704
Closed

Add checklist item to PR template for addition of static assets #5646

DrGFreeman opened this issue Nov 19, 2020 · 0 comments · Fixed by #5704

Comments

@DrGFreeman
Copy link
Contributor

Description

Add a checklist item to the PR template to ensure that if static assets are added, they are included in the AppArmor profile, as well as in the securedrop-app-code debian package.

User Research Evidence

In #5593, icon files were added in a new folder at static/icons/ however, the new folder and its content were not added to the .rsync_filter file, resulting in the icons being from the Debian package. New issue and PR (#5625/#5628) had to be raised to add the folder and icons to the .rsync_filter file.

Also, the initial submission of #5593 did not add the icons to the AppArmor profile. They were added as part of the PR review process.

User Stories

As a external contributor, I want the PR template checklist to act as a reference so I can ensure my PR is complete, including changes I need to include that I may not be aware of.

As a PR reviewer, I want the checklist to be as complete as possible to reduce the number of details I need to remember to check when reviewing a PR. I also want to avoid follow-up PRs to fix details missed in the first review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant