Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable v2 support for Focal installs #5687

Closed
eloquence opened this issue Jan 5, 2021 · 5 comments · Fixed by #5819
Closed

Disable v2 support for Focal installs #5687

eloquence opened this issue Jan 5, 2021 · 5 comments · Fixed by #5819
Labels
needs/discussion queued up for discussion at future team meeting. Use judiciously.
Milestone

Comments

@eloquence
Copy link
Member

eloquence commented Jan 5, 2021

(Part of #5731)

Per our roadmap, support for v2 onion services will be removed for fresh installs starting with SecureDrop 1.8.0 (tentative release date: 2021-02-23). Accordingly, in addition to disabling v2 onion services during restores (#5677), we should ensure that v2 onion services cannot be configured during a fresh install of SecureDrop 1.8.0 or later.

Currently, during the installation, the user is prompted whether they want to enable v2 and/or v3 onion services, with a deprecation warning for v2:
https://github.com/freedomofpress/securedrop/blob/develop/admin/securedrop_admin/__init__.py#L435-L447

Instead, starting with SecureDrop 1.8.0, we can simply enforce v3 onion services. This should not preclude a v2 onion service from being restored on Xenial.

This is consistent with the language in our previous deprecation warning ("support for v2 onion services will be removed in February 2021").

@eloquence eloquence added this to the 1.8.0 milestone Jan 5, 2021
@eloquence eloquence changed the title Disable v2 support for Focal installs Disable v2 support for fresh installs Jan 5, 2021
@eloquence
Copy link
Member Author

One open question: Do we want to preserve the existing behavior of ./securedrop-admin sdconfig as-is for previously configured Xenial installs, or do we want to modify it in any way? I think we need to preserve it, so admins can still go through the documented process of v2 -> v2+v3 -> v3 to make the switch.

In that case, we need to detect on an ./securedrop-admin sdconfig invocation whether this is a fresh install, and only in that case, the onion service configuration options would be hidden.

@eloquence
Copy link
Member Author

eloquence commented Jan 21, 2021

This is not on the 1/21-2/4 sprint as we're currently still focused on completing and stabilizing Focal support. However, in the coming days, I suggest we finalize the acceptance criteria for this issue.

@eloquence eloquence added the needs/discussion queued up for discussion at future team meeting. Use judiciously. label Jan 21, 2021
@eloquence
Copy link
Member Author

Discussed during standup and a bit more w/ @zenmonkeykstop later. I'll take a look at the sdconfig portion today/tomorrow; current plan of record is to suppress the v2 option if no existing configuration value for it is present. Additionally, we may want to bail early in the install playbook if the server target is running Focal and the user is attempting to enable v2 onion services.

@eloquence eloquence changed the title Disable v2 support for fresh installs Disable v2 support for new Focal installs Feb 23, 2021
@eloquence eloquence changed the title Disable v2 support for new Focal installs Disable v2 support for Focal installs Feb 23, 2021
@eloquence
Copy link
Member Author

Retitled for clarity. As further discussed in standup today, there are two parts to resolving this issue:

  1. Modifying the language in sdconfig to make it clear that v2 onion services can only be enabled for Ubuntu 16.04 installs, which is supported for a limited time;

  2. Bailing early in the install playbook if a server is running Ubuntu 20.04 and v2 is enabled (IMO regardless of v3 state).

I'll make a tiny string change PR for 1) later and will close the more complex #5811 which seems unduly risky at this late stage.

@zenmonkeykstop and @rmol have offered to look into 2) today or tomorrow.

@eloquence
Copy link
Member Author

  1. above is now tracked in Disable v2 installs on Focal systems #5818.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/discussion queued up for discussion at future team meeting. Use judiciously.
Projects
None yet
1 participant