-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable v2 support for Focal installs #5687
Comments
One open question: Do we want to preserve the existing behavior of In that case, we need to detect on an |
This is not on the 1/21-2/4 sprint as we're currently still focused on completing and stabilizing Focal support. However, in the coming days, I suggest we finalize the acceptance criteria for this issue. |
Discussed during standup and a bit more w/ @zenmonkeykstop later. I'll take a look at the |
Retitled for clarity. As further discussed in standup today, there are two parts to resolving this issue:
I'll make a tiny string change PR for 1) later and will close the more complex #5811 which seems unduly risky at this late stage. @zenmonkeykstop and @rmol have offered to look into 2) today or tomorrow. |
|
(Part of #5731)
Per our roadmap, support for v2 onion services will be removed for fresh installs starting with SecureDrop 1.8.0 (tentative release date: 2021-02-23). Accordingly, in addition to disabling v2 onion services during restores (#5677), we should ensure that v2 onion services cannot be configured during a fresh install of SecureDrop 1.8.0 or later.
Currently, during the installation, the user is prompted whether they want to enable v2 and/or v3 onion services, with a deprecation warning for v2:
https://github.com/freedomofpress/securedrop/blob/develop/admin/securedrop_admin/__init__.py#L435-L447
Instead, starting with SecureDrop 1.8.0, we can simply enforce v3 onion services. This should not preclude a v2 onion service from being restored on Xenial.
This is consistent with the language in our previous deprecation warning ("support for v2 onion services will be removed in February 2021").
The text was updated successfully, but these errors were encountered: