Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Maximum Members for Council and Technical Committee in Configurations #872

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Nov 14, 2024

PR Type

enhancement


Description

  • Set maximum members for the Council to 7 and for the Technical Committee to 5 in the collective.rs configuration.
  • Updated the DesiredMembers in election_phragmen.rs to use the new MaxMembersCouncil constant.
  • Modified the membership.rs configuration to use MaxMembersTechnicalCommittee for the Technical Committee.

Changes walkthrough 📝

Relevant files
Enhancement
collective.rs
Set maximum members for Council and Technical Committee   

runtime/laos/src/configs/collective.rs

  • Changed MaxMembers to MaxMembersCouncil and
    MaxMembersTechnicalCommittee.
  • Set maximum members for Council to 7.
  • Set maximum members for Technical Committee to 5.
  • +4/-3     
    election_phragmen.rs
    Update DesiredMembers to MaxMembersCouncil                             

    runtime/laos/src/configs/election_phragmen.rs

    • Updated DesiredMembers to use MaxMembersCouncil.
    +1/-2     
    membership.rs
    Update MaxMembers for Technical Committee Membership         

    runtime/laos/src/configs/membership.rs

    • Updated MaxMembers to MaxMembersTechnicalCommittee.
    +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions github-actions bot changed the title Feature/set max members collectives Set Maximum Members for Council and Technical Committee in Configurations Nov 14, 2024
    Copy link

    PR Description updated to latest commit (54470cd)

    @asiniscalchi
    Copy link
    Member Author

    /describe

    Copy link

    PR Description updated to latest commit (688447f)

    @asiniscalchi asiniscalchi merged commit 4916490 into main Nov 14, 2024
    8 checks passed
    @asiniscalchi asiniscalchi deleted the feature/set_max_members_collectives branch November 14, 2024 13:22
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants