Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support compressed resources #191

Closed
roll opened this issue Oct 12, 2017 · 5 comments · Fixed by #241
Closed

Support compressed resources #191

roll opened this issue Oct 12, 2017 · 5 comments · Fixed by #241
Labels
feature

Comments

@roll
Copy link
Member

roll commented Oct 12, 2017 •
edited
Loading

Overview

For now it's on a discussion stage on the specs level - frictionlessdata/datapackage#290. This issue is for initial thoughts on how it could be done on the implementations level.

Requires frictionlessdata/tabulator-py#197
@roll roll added the feature label Oct 12, 2017
@roll roll mentioned this issue Oct 12, 2017
Closed
@Mikanebu
Copy link

@roll I am trying to use tabulator-py for remote .zip format and it throws Unknown format ‘zip’. I hope that this feature will solve it. Looking forward to see this feature.

@roll
Copy link
Member Author

roll commented Nov 15, 2017 •
edited
Loading

@Mikanebu
tabulator supports zip from v1.10 - https://github.com/frictionlessdata/tabulator-py#v110. So if it still doesn't work for datapackage it should be something simple like some not passed arguments etc. Would you like to take a look and PR?

@Mikanebu
Copy link

@roll It takes to stream.py, line 143, where it looks for zip parsers, but there is no parser. Am I in right way? Seems like there is no support for zip or gz.

@roll
Copy link
Member Author

roll commented Nov 15, 2017

@Mikanebu
Could you check tabulator version used.

@Mikanebu
Copy link

@roll It is version 1.7.1, I will try with updated version, sorry for taking your time

@roll roll removed the {contribute} label May 20, 2019
@roll roll mentioned this issue Aug 16, 2019
Merged
@roll roll closed this as completed in #241 Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implemented support for compression frictionlessdata/datapackage-py
2 participants
@roll @Mikanebu