Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase da1660d: 'missing value per field pattern' #714

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Rebase da1660d: 'missing value per field pattern' #714

merged 1 commit into from
Dec 15, 2020

Conversation

dcslagel
Copy link
Contributor

Description:

This is a 'rebase' of #608 'Missing value per field pattern'. I didn't find a straight forward way to pull the original commit da1660d from specs/patterns.mdto the new file patterns/README.md. So this change manually takes the change content of da1660d and adds it to the bottom of the current file. It didn't look like there was any particular order to the sections in patterns/README.md so I added da1660d's content to the end of the file. Let me know if this needs to be moved and I'll make the change.

Original information:

Author: Stephen-Gates Stephen.Gates@me.com
Date: Sat Apr 7 20:40:44 2018 +1000
WIP missing value per field pattern
as per https://discuss.okfn.org/t/missing-values-per-field-pattern/6571

Notes:

If this change is no longer desired, go ahead and close this pull request.
If this change is accepted then #608 can probably be closed when this pull-request merges.

Testing:

Pushed this branch to my fork and visually verified the new content regarding 'Missing Values..' is visible in patterns/README.md.

--
Let me know if this change could be accepted (or rejected) or
needs some additional changes to be approved and merged.

Thank you,
DC

Original information:
Author: Stephen-Gates <Stephen.Gates@me.com>
Date:   Sat Apr 7 20:40:44 2018 +1000
WIP missing value per field pattern
as per https://discuss.okfn.org/t/missing-values-per-field-pattern/6571
@Stephen-Gates
Copy link
Contributor

@dcslagel Thank you for doing this 👍

@rufuspollock
Copy link
Contributor

@dcslagel thank-you very much and this looks great. Well done and much appreciated!

@rufuspollock rufuspollock merged commit adf86c5 into frictionlessdata:master Dec 15, 2020
@dcslagel dcslagel deleted the missing-value-per-field-pattern-rebase branch December 15, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants