added an optional parameter to specify the character encoding of a source #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I have added an optional parameter to specify the character encoding of a source. The test TableEncodingTests::createTableFromIso8859() passes.
However, I'm not at all sure that my approach makes sense in context of the rest of the code/framework. Somehow we would have to transfer the
encoding
property from the Tabular Data Resource to theTable.fromSource
method invocation.Closes #77
Please preserve this line to notify @iSnow (lead of this repository)