Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evenement eventemitter extension #55

Closed
WyriHaximus opened this issue Jun 18, 2018 · 1 comment · Fixed by #56
Closed

Evenement eventemitter extension #55

WyriHaximus opened this issue Jun 18, 2018 · 1 comment · Fixed by #56
Labels
easy pick maintenance
Milestone
v0.4.0

Comments

@WyriHaximus
Copy link
Member

Is there any reason this package extends Evenements event emitter instead of using it's API. Seems the only thing it adds are chainable methods with on, which is currently support in all the latest version of evenement 1, 2, and 3.
@clue clue mentioned this issue Jun 19, 2018
Merged
@clue clue added this to the v0.4.0 milestone Jun 19, 2018
@clue
Copy link
Contributor

clue commented Jun 19, 2018

Yes, this is not actually needed, see also #56 :shipit: 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy pick maintenance
Projects
None yet
Milestone
v0.4.0
2 participants
@WyriHaximus @clue