Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes calling method on non-object in handleEvent method #30

Merged
merged 1 commit into from
Sep 30, 2017
Merged

Fixes calling method on non-object in handleEvent method #30

merged 1 commit into from
Sep 30, 2017

Conversation

khelle
Copy link
Contributor

@khelle khelle commented Aug 1, 2015

This is suggested change to fix issue #29

@WyriHaximus WyriHaximus added this to the 0.3.1 milestone Sep 30, 2017
WyriHaximus
WyriHaximus approved these changes Sep 30, 2017
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

clue
clue approved these changes Sep 30, 2017
View reviewed changes
Copy link
Contributor

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and filing this PR! :shipit: 🎉

@WyriHaximus WyriHaximus merged commit 3926b25 into friends-of-reactphp:master Sep 30, 2017
@WyriHaximus WyriHaximus modified the milestones: v0.3.1, v0.4.0 Mar 7, 2018
@clue clue mentioned this pull request Oct 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@khelle @jsor @WyriHaximus @clue